Reformat the gaussian conditional sampler #366
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 99.43% 99.38% -0.06%
==========================================
Files 22 20 -2
Lines 1247 1140 -107
==========================================
- Hits 1240 1133 -107
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
Thx for this refactoring. I have two relatively minor comments.
jpaillard
left a comment
jpaillard
left a comment
There was a problem hiding this comment.
Thanks, I agree that having both samplers implemented as classes makes sense.
jpaillard
left a comment
jpaillard
left a comment
There was a problem hiding this comment.
I think it limits extra work to integrate the test in this PR rather than having to fix something in an upcoming one. I made a suggestion for the tests.
Co-authored-by: Joseph Paillard <[email protected]>
Co-authored-by: Joseph Paillard <[email protected]>
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
The PR is almost ready to merge
Co-authored-by: bthirion <[email protected]>
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
Needs a bit of fine tuning.
Co-authored-by: bthirion <[email protected]>
[skip tests]
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
Given #488, I have no further comments than @jpaillard's ones.
Co-authored-by: Joseph Paillard <[email protected]>
Co-authored-by: Joseph Paillard <[email protected]>
Co-authored-by: Joseph Paillard <[email protected]>
Co-authored-by: Joseph Paillard <[email protected]>
jpaillard
left a comment
jpaillard
left a comment
There was a problem hiding this comment.
Thank you for the changes
3 participants
I reformat the Gaussian estimation of knockoff in the format of classes, as conditional sampling.
I moved all the conditional samplers into statistical_tool.